Skip to content

Decode CF metadata for pre-opened datasets#706

Merged
djhoese merged 1 commit intopytroll:mainfrom
Zaczero:pr/decode-cf-preopened-dataset
Mar 6, 2026
Merged

Decode CF metadata for pre-opened datasets#706
djhoese merged 1 commit intopytroll:mainfrom
Zaczero:pr/decode-cf-preopened-dataset

Conversation

@Zaczero
Copy link
Contributor

@Zaczero Zaczero commented Mar 1, 2026

Inspired by #702, _open_nc_file would fail to decode types when xr.Dataset was passed.

  • Tests added
  • Tests passed

(cherry picked from commit a8fedea)
(cherry picked from commit 997480a)
@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.68%. Comparing base (4da28b0) to head (21688a8).
⚠️ Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #706      +/-   ##
==========================================
+ Coverage   93.67%   93.68%   +0.01%     
==========================================
  Files          89       89              
  Lines       13621    13656      +35     
==========================================
+ Hits        12759    12794      +35     
  Misses        862      862              
Flag Coverage Δ
unittests 93.68% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djhoese djhoese added the bug label Mar 4, 2026
@djhoese djhoese self-assigned this Mar 4, 2026
@djhoese djhoese requested review from mraspaud and pnuu March 4, 2026 20:18
@djhoese
Copy link
Member

djhoese commented Mar 4, 2026

I think this makes sense to me. Thanks for the improvement. @pnuu @mraspaud or anyone else have opinions? It would make sense that if you want to load an area from a CF dataset that you need to actually decode CF information first.

@djhoese djhoese merged commit 60e6132 into pytroll:main Mar 6, 2026
26 checks passed
@djhoese
Copy link
Member

djhoese commented Mar 6, 2026

Thanks @Zaczero!

@Zaczero Zaczero deleted the pr/decode-cf-preopened-dataset branch March 6, 2026 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants