Changing the count parameter type from int to size_t in reduction algorithms.#380
Open
piotrchmiel wants to merge 3 commits intopytorch:mainfrom
Open
Changing the count parameter type from int to size_t in reduction algorithms.#380piotrchmiel wants to merge 3 commits intopytorch:mainfrom
piotrchmiel wants to merge 3 commits intopytorch:mainfrom
Conversation
piotrchmiel
commented
Jan 22, 2024
- Int means that user cannot pass an array size larger than numeric_limits::max
- Signed type deosn't make sense regarding the size of the array, which cannot be less than 0.
- In many places under the hood, count is converted to size_t anyway, e.g. malloc
- gloo/gloo/allreduce.h uses size_t as number of elements which is inconsistent with other reduction algorithms
- ReductionFunction takes size_t as count parameter
- While experimenting with examples, I ran into a problem with the number of elements being limited by int. It took me a while to figure out why the code wasn't working. Other users may also encounter this problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.