gh-143460: Correct unlimited stack size skip for Emscripten #143765
Conversation
|
!buildbot emscripten |
|
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 43b53af 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F143765%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
| if is_emscripten or is_wasi or os.name == "nt": | ||
| return test | ||
|
|
||
| import resource |
There was a problem hiding this comment.
Another option is to remove if is_wasi or os.name == "nt": and replace it with a more a generic:
| import resource | |
| try: | |
| import resource | |
| except ImportError: | |
| return test |
There was a problem hiding this comment.
I thought about that approach, but I figured it would be better to be explicit about when resource is a required module so that you catch a case where resource fails to compile for some reason.
|
Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…thonGH-143765) Modifies the test skip for unlimited stack size to add Emscripten to the exclusion list. (cherry picked from commit 1857a40) Co-authored-by: Russell Keith-Magee <[email protected]>
|
GH-143819 is a backport of this pull request to the 3.14 branch. |
…H-143765) (#143819) Modifies the test skip for unlimited stack size to add Emscripten to the exclusion list. (cherry picked from commit 1857a40) Co-authored-by: Russell Keith-Magee <[email protected]>
3 participants
#143606 added a test skip decorator for tests when an infinite stack size is configured. That test skip included a shortcut for WASI (which doesn't have a
resourcemodule), but missing Emscripten (which has the same limitation).test_functools/test_json#143460