Add support for Canvas ltiLaunchUrl in outcome request#77
Open
hmoffatt wants to merge 2 commits intopylti:masterfrom
Open
Add support for Canvas ltiLaunchUrl in outcome request#77hmoffatt wants to merge 2 commits intopylti:masterfrom
hmoffatt wants to merge 2 commits intopylti:masterfrom
Conversation
hmoffatt
force-pushed
the
ltiLaunchUrl
branch
from
9198f48 to
83da2ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canvas LMS supports an extra field in the outcome request's resultData field called
ltiLaunchUrl(in addition to the standardtextandurlfields). If present, Canvas will launch the URL as an LTI tool (whileurljust shows a page).I need this in my application so I've added it in. It's non-standard though so you may not want to accept this.
Also, the code could be cleaned up a bit more now that there's three possible fields in the resultData, and also there needs to be unit tests added for all of the resultData code.