[bwitt]

Summary

Allow hkps URLs for apt::keyserver like apt::key's server, via a new type Apt::Keyserver.
Change apt and apt::key to use this new type

Related Issues (if any)

Fixes #1213

Checklist

• 🟢 Spec tests.
• 🟢 Acceptance tests.
• Manually verified. (For example puppet apply)

[jst-cyr]

Hey @bwitt , thanks for opening up this PR. It's good to get this fixed up, but I'm wondering if the fix should actually be over in the type. Tightening up the types accepted seems like a good idea, rather than going with a complex regex that could be more difficult to maintain.

Looking at Stdlib::Host it seems like it allows the types Fqdn and IP::Address. It seems to be missing the types that would cover what we need here.

I know this RegEx pattern for types is already used elsewhere in the module, but perhaps we can solve this a different way that keeps the benefits of a stronger type?

Perhaps a new type in this module that composes Stdlib::Host with the missing hkp/hkps pattern and that way the code can still have a strong type and we can centralize that RegEx management into a single place (while still inheriting the benefits of the Stdlib Host type?)

[bwitt]

@jst-cyr done! thanks!

[jst-cyr]

Thanks @bwitt , I'll get some testing going!

[jst-cyr]

Running CI tests for this PR here: #1328

[jst-cyr]

Acceptance Test Results: https://github.com/puppetlabs/puppetlabs-apt/actions/runs/39711758732?pr=1328

✅ Full green test results!
Still needs engineering review.