Repository navigation
Conversation
smortex
previously approved these changes
Oct 11, 2026
smortex
left a comment
smortex
left a comment
Collaborator
There was a problem hiding this comment.
That looks reasonable.
I would love to see some CI that prove that after moving these code blockes there is no impact on existing test cases, but CI is broken when your PR comes from a third party repository 😠. We will have to wait for Perfoce to do the actual testing…
Author
|
thanks! |
smortex
approved these changes
Oct 12, 2026
Signed-off-by: Brian Witt <brianwitt@gmail.com>
jst-cyr
force-pushed
the
deb822-key-pin
branch
from
October 16, 2026 02:34
e1da10a to
c84c642
Compare
Member
|
Thanks for the PR @bwitt ! I did a rebase to get this updated and will launch the acceptance tests so we can get some extra feedback. Basic unit tests look good. |
Member
|
Running CI tests for this PR in #1312 |
Member
|
Acceptance Test Results: https://github.com/puppetlabs/puppetlabs-apt/actions/runs/38841363561?pr=1312 Full green on acceptance tests! Ready for review by engineering when available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow
apt::sourcewithsource_format => 'sources'to acceptkeyandpin, just likelist.Moved the code up so it is used by both.
If
pinis a string or int, applies to the first source.Add tests + acceptance test, and an example.
Additional Context
Add any additional context about the problem here.
listsupport (in fact use the same code as much as possible)Related Issues (if any)
Fixes #1300
Checklist
puppet apply)