Skip to content

Add support for auth management as part of source resources - #1295

Open
UiP9AV6Y wants to merge 1 commit into
puppetlabs:mainfrom
UiP9AV6Y:feature/apt-source-auth
Open

UiP9AV6Y wants to merge 1 commit into
puppetlabs:mainfrom
UiP9AV6Y:feature/apt-source-auth

Conversation

@UiP9AV6Y

@UiP9AV6Y UiP9AV6Y commented Oct 2, 2026 •

Copy link
Copy Markdown

Summary

similar to key management, auth credentials for sources can be managed from within the resource. the resource is named after the source and can optionally be removed if needed. the configured credentials are only valid for their associated repository as the auth machine scope is set to the repo location.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

similar to key management, auth credentials for sources can be
managed from within the resource. the resource is named after
the source and can optionally be removed if needed.
the configured credentials are only valid for their associated
repository as the auth machine scope is set to the repo location.
@jst-cyr

jst-cyr commented Oct 5, 2026

Copy link
Copy Markdown
Member

Running CI tests for this PR here: #1296

@jst-cyr

jst-cyr commented Oct 5, 2026

Copy link
Copy Markdown
Member

Thank you for the PR @UiP9AV6Y ! I'm going to kick off some acceptance tests to get you some initial feedback.

@jst-cyr

jst-cyr commented Oct 5, 2026

Copy link
Copy Markdown
Member

Acceptance Test Results: https://github.com/puppetlabs/puppetlabs-apt/actions/runs/37344670001?pr=1296

Looks like a full green across the board, except for Debian 11 which has acceptance test failures. These tests seem to match with nightly failures against the main branch, so not related to this PR but it looks like we probably need a separate PR to resolve that Debian 11 issue.

Otherwise, this one looks good to go for review, tests are good!

@jst-cyr

jst-cyr commented Oct 5, 2026

Copy link
Copy Markdown
Member

Quick update: I found #1292 and it has passing Debian 11 tests. It seems to resolve the issue there, so I've raised the priority on that one so we can get that reviewed and merged and resolve the testing issues for Debian 11. Then we'll be able to pull that down into this PR and redo the test suite and validate that it is full green even on Debian 11.

@jst-cyr

jst-cyr commented Oct 5, 2026

Copy link
Copy Markdown
Member

After rebasing #1292 and rerunning tests, it also failed. Debian 11 appears to be an issue in the infra with provisioning, not something caused by this PR and not something fixed in other PRs. We are still considered 'green' and the Debian 11 issue needs to be resolved at infra level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants