Skip to content

Avoid crash when no app can open an external intent #1675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jim-daf wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −1
Open

Avoid crash when no app can open an external intent #1675

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion android/app/src/main/java/gallery/memories/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package gallery.memories

import android.annotation.SuppressLint
import android.content.ActivityNotFoundException
import android.content.Intent
import android.content.res.Configuration
import android.graphics.Color
Expand Down Expand Up @@ -230,7 +231,11 @@ class MainActivity : AppCompatActivity() {
}

// Open external links in browser
Intent(Intent.ACTION_VIEW, request.url).apply { startActivity(this) }
try {
Intent(Intent.ACTION_VIEW, request.url).apply { startActivity(this) }
} catch (e: ActivityNotFoundException) {
Toast.makeText(view.context, "No app found to open this link", Toast.LENGTH_SHORT).show()
}

return true
}
Expand Down