Skip to content

Fix public uploads for nextcloud subdirectories #1619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gouverneurp wants to merge 3 commits into
base: master
Choose a base branch
from
+24 −3
Open

Fix public uploads for nextcloud subdirectories #1619

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b902651
Merge pull request #1 from pulsejet/master
gouverneurp Feb 10, 2026
f1524d1
Fix public uploads in nextcloud instances with subdirectory
gouverneurp Feb 10, 2026
6b3b6c2
Apply 'prettier'
gouverneurp Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 24 additions & 3 deletions src/components/upload/PublicUploadHandler.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,14 @@ export default defineComponent({
canUpload(): boolean {
return this.routeIsPublic && this.initstate.allow_upload === true;
},

/**
* Get the base URL including any subdirectory where Nextcloud is installed
*/
baseUrl(): string {
const webroot = (window as any).OC?.webroot || '';
return window.location.origin + webroot;
},
},

methods: {
Expand Down Expand Up @@ -76,7 +84,7 @@ export default defineComponent({
try {
const token = this.$route.params.token;
const uploadPath = this.getCurrentPath();
const publicDavPath = `${window.location.origin}/public.php/dav/files/${token}${uploadPath}`;
const publicDavPath = `${this.baseUrl}/public.php/dav/files/${token}${uploadPath}`;

const client = createClient(publicDavPath);
const contents = (await client.getDirectoryContents('/', { details: false })) as Array<FileStat>;
Expand Down Expand Up @@ -125,12 +133,25 @@ export default defineComponent({

// Setup WebDAV destination
const token = this.$route.params.token as string;
const remoteURL = `${window.location.origin}/public.php/dav`;
const currentPath = this.getCurrentPath();

// Build the absolute URL properly
const protocol = window.location.protocol;
const host = window.location.host;
const webroot = (window as any).OC?.webroot || '';

// Construct the full URL ensuring it's absolute
const baseURL = `${protocol}//${host}${webroot}`;
const davPath = '/public.php/dav';
const rootPath = `/files/${token}`;
const fullPath = `${rootPath}${currentPath}`;

// The source must be a complete URL
const folderSource = `${baseURL}${davPath}${fullPath}`;

const destination = new Folder({
id: 0,
source: remoteURL + rootPath + this.getCurrentPath(),
source: folderSource,
root: rootPath,
owner: null,
permissions: Permission.CREATE,
Expand Down