Skip to content

remove classcast exception on topology.message.timeout.secs #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aemrob wants to merge 2 commits into
base: master
Choose a base branch
from
Open

remove classcast exception on topology.message.timeout.secs #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
838ca44
remove classcast exception on topology.message.timeout.secs
aemrob Jan 3, 2017
2498e76
added test with Long topology.message.timeout.secs
Jan 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/java/org/apache/storm/jms/spout/JmsSpout.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,10 +156,10 @@ public void open(Map conf, TopologyContext context,
if(this.tupleProducer == null){
throw new IllegalStateException("JMS Tuple Producer has not been set.");
}
Integer topologyTimeout = (Integer)conf.get("topology.message.timeout.secs");
Long topologyTimeout = (Long)conf.get("topology.message.timeout.secs");
// TODO fine a way to get the default timeout from storm, so we're not hard-coding to 30 seconds (it could change)
topologyTimeout = topologyTimeout == null ? 30 : topologyTimeout;
if( (topologyTimeout.intValue() * 1000 )> this.recoveryPeriod){
topologyTimeout = topologyTimeout == null ? new Long(30L) : topologyTimeout;
if( (topologyTimeout.intValue() * 1000) > this.recoveryPeriod){
LOG.warn("*** WARNING *** : " +
"Recovery period ("+ this.recoveryPeriod + " ms.) is less then the configured " +
"'topology.message.timeout.secs' of " + topologyTimeout +
Expand Down
6 changes: 5 additions & 1 deletion src/test/java/org/apache/storm/jms/spout/JmsSpoutTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,11 @@ public void testFailure() throws JMSException, Exception{
spout.setJmsTupleProducer(new MockTupleProducer());
spout.setJmsAcknowledgeMode(Session.CLIENT_ACKNOWLEDGE);
spout.setRecoveryPeriod(10); // Rapid recovery for testing.
spout.open(new HashMap<String,String>(), null, collector);

HashMap<String,Object> conf = new HashMap<String,Object>();
conf.put("topology.message.timeout.secs", new Long(10L));
spout.open(conf, null, collector);

Message msg = this.sendMessage(mockProvider.connectionFactory(), mockProvider.destination());
Thread.sleep(100);
spout.nextTuple(); // Pretend to be storm.
Expand Down