Skip to content

Spotless jdk profile #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
psxjoy wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Spotless jdk profile #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c243c64
chore: update pom.xml for improved formatting and add JDK 9+ profile
psxjoy Jul 23, 2025
d5cd47d
chore: update pom.xml for improved formatting and add JDK 9+ profile
psxjoy Jul 23, 2025
645c922
chore: update pom.xml to use variable for argLine configuration
psxjoy Jul 23, 2025
696d1cd
chore: update pom.xml to use variable for argLine configuration
psxjoy Jul 23, 2025
7f97fb8
chore: update pom.xml to use variable for argLine configuration
psxjoy Jul 23, 2025
ff5e50c
chore: update pom.xml to skip tests and add file encoding to surefire…
psxjoy Jul 23, 2025
a00a627
chore: update pom.xml to enable tests and modify JDK profiles
psxjoy Jul 23, 2025
62e879a
chore: update pom.xml to enable tests and modify JDK profiles
psxjoy Jul 23, 2025
d8625fe
Apply suggestion from @tisonkun
psxjoy Jul 25, 2025
2185b7f
Apply suggestion from @tisonkun
psxjoy Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,7 @@ jobs:
restore-keys: |
${{ runner.os }}-m2
- name: Test with Maven
if: ${{ matrix.java == '8' }}
run: ./mvnw test -B -Dmaven.test.skip=false
- name: Test with Maven
if: ${{ matrix.java != '8' }}
run: ./mvnw test -B -Dmaven.test.skip=false -DargLine="--add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/sun.reflect.annotation=ALL-UNNAMED"
- name: Publish Unit Test Results
uses: EnricoMi/publish-unit-test-result-action@v2
if: (!cancelled())
Expand Down
28 changes: 25 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,9 @@
<artifactId>maven-surefire-plugin</artifactId>
<version>${maven-surefire-plugin.version}</version>
<configuration>
<argLine>${argLine} -Dfile.encoding=UTF-8</argLine>
<argLine>
${argLine} ${surefireArgLine}
</argLine>
</configuration>
<!-- please add below configuration if you are using JDK 9 or higher-->
<!-- <configuration>-->
Expand Down Expand Up @@ -413,8 +415,8 @@
</indent>
</java>
<pom>
<trimTrailingWhitespace />
<endWithNewline />
<trimTrailingWhitespace/>
<endWithNewline/>
<indent>
<spaces>true</spaces>
<spacesPerTab>4</spacesPerTab>
Expand Down Expand Up @@ -445,4 +447,24 @@
</plugin>
</plugins>
</build>
<profiles>
<profile>
<id>jdk9plus</id>
<activation>
<jdk>[9,)</jdk>
</activation>
<properties>
<surefireArgLine>--add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/sun.reflect.annotation=ALL-UNNAMED -Dfile.encoding=UTF-8</surefireArgLine>
</properties>
</profile>
<profile>
<id>jdk8</id>
<activation>
<jdk>1.8</jdk>
</activation>
<properties>
<surefireArgLine> -Dfile.encoding=UTF-8</surefireArgLine>
</properties>
</profile>
</profiles>
</project>