Repository navigation
Conversation
LexxXell
force-pushed
the
feat/identityTopUpFromPlatform
branch
from
September 27, 2026 14:06
68df8d2 to
a5c7429
Compare
This was referenced Sep 27, 2026
Collaborator
Author
|
Superseded by #177. The funding journal chain is parked on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Top-up of an existing identity paid from one of the wallet's own Platform addresses — the counterpart of the registration in #171, on the same journal.
IdentityFundingService.quotePlatformnow signs either transition: identity create for a registration,IdentityTopUpFromAddressesfor a top-up of the identity the payload names.TOP_UP_IDENTITY_FROM_PLATFORM_ADDRESSconfirms such a quote by broadcasting the stored bytes and waiting for Platform to credit the identity. No identity is created, so nothing is resolved or saved afterwards.Everything else is inherited: the address is the one asked for or the largest covering the amount, the nonce is signed into the bytes so a retry sends exactly them, and while the operation is pending the wallet's other Platform spends are refused.
Backend only — no UI changes.
Testing
tsc --noEmit,ts-standardtest/api/private/identities/identityFunding.spec.ts— four new cases: a top-up quote stores signed bytes and reserves no identity index; confirming sends exactly those bytes, makes no identity lookup and never touches Core; a top-up without a valid identifier is refused byvalidatePayload; a pending top-up cannot be confirmed through the registration handler.jest: 44 suites, 19 cases in the funding spec; the only failures are the network-dependent specs that flake ondeveloptoo and pass on a re-run.