Fix sync failed for some seeds - #157
Merged
Merged
Conversation
pshenmic
requested changes
Aug 30, 2026
| "dash-core-p2p@https://github.com/pshenmic/dash-core-p2p#7c40475607faf2b9a68d2f897a862b8e249cb2cc": | ||
| version "0.0.1" | ||
| resolved "https://github.com/pshenmic/dash-core-p2p#542a9d9e250c898e8b7a9ed2781cccaba52739f0" | ||
| resolved "https://github.com/pshenmic/dash-core-p2p#7c40475607faf2b9a68d2f897a862b8e249cb2cc" |
Owner
There was a problem hiding this comment.
Why not over a new dash core p2p version?
pshenmic
approved these changes
Aug 30, 2026
pshenmic
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
P2P stack uses core sdk for serialization and deserialization data objects. When seed contains tx in block, p2p must decode whole block and in some blocks exists cbtx's script of which core sdk cannot deserialize normally and as result we getting offset error on deserialize
Example of bad block: https://dashscan.io/blocks/000000000000000c9253abbeeafddfa08c8aaec02fd2dedfcf3fa467be5cdc31
Things done