Skip to content

Remove proxy_remove_header_map_value. #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PiotrSikora wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove proxy_remove_header_map_value. #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 11 additions & 31 deletions abi-versions/vNEXT/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,31 +751,16 @@ Returned `status` value is:
Adds or replaces key's (`key_data`, `key_value`) value with the provided
value (`value_data`, `value_size`) in the map `map_id`.

If the `value_data` is `0`, then the key (`key_data`, `key_size`) will be
removed from the map `map_id`.

Returned `status` value is:
- `OK` on success.
- `BAD_ARGUMENT` for unknown `map_id`.
- `INVALID_MEMORY_ACCESS` when `key_data`, `key_size`, `value_data`
and/or `value_size` point to invalid memory address.


#### `proxy_remove_header_map_value`

* params:
- `i32 (`[`proxy_map_type_t`]`) map_id`
- `i32 (const char *) key_data`
- `i32 (size_t) key_size`
* returns:
- `i32 (`[`proxy_status_t`]`) status`

Removes the key (`key_data`, `key_value`) from the map `map_id`.

Returned `status` value is:
- `OK` on success (including the case when the requested key didn't exist).
- `BAD_ARGUMENT` for unknown `map_id`.
- `INVALID_MEMORY_ACCESS` when `key_data` and/or `key_size` point to
invalid memory address.


## Common HTTP and TCP stream operations

### Functions exposed by the host
Expand Down Expand Up @@ -970,9 +955,8 @@ All `num_headers` headers can be retrieved and/or modified using
with `map_id` set to `HTTP_REQUEST_HEADERS`.

Individual HTTP request headers can be retrieved and/or modified using
[`proxy_get_header_map_value`], [`proxy_replace_header_map_value`],
[`proxy_add_header_map_value`] and/or [`proxy_remove_header_map_value`]
with `map_id` set to `HTTP_REQUEST_HEADERS`.
[`proxy_get_header_map_value`], [`proxy_replace_header_map_value`] and/or
[`proxy_add_header_map_value`] with `map_id` set to `HTTP_REQUEST_HEADERS`.

Paused HTTP requests can be resumed using [`proxy_continue_stream`]
or closed using [`proxy_close_stream`] with `stream_type` set to
Expand Down Expand Up @@ -1033,9 +1017,8 @@ All `num_trailers` trailers can be retrieved and/or modified using
with `map_id` set to `HTTP_REQUEST_TRAILERS`.

Individual HTTP request trailers can be retrieved and/or modified using
[`proxy_get_header_map_value`], [`proxy_replace_header_map_value`],
[`proxy_add_header_map_value`] and/or [`proxy_remove_header_map_value`]
with `map_id` set to `HTTP_REQUEST_TRAILERS`.
[`proxy_get_header_map_value`], [`proxy_replace_header_map_value`] and/or
[`proxy_add_header_map_value`] with `map_id` set to `HTTP_REQUEST_TRAILERS`.

Paused HTTP requests can be resumed using [`proxy_continue_stream`]
or closed using [`proxy_close_stream`] with `stream_type` set to
Expand Down Expand Up @@ -1065,9 +1048,8 @@ All `num_headers` headers can be retrieved and/or modified using
with `map_id` set to `HTTP_RESPONSE_HEADERS`.

Individual headers can be retrieved and/or modified using
[`proxy_get_header_map_value`], [`proxy_replace_header_map_value`],
[`proxy_add_header_map_value`] and/or [`proxy_remove_header_map_value`]
with `map_id` set to `HTTP_RESPONSE_HEADERS`.
[`proxy_get_header_map_value`], [`proxy_replace_header_map_value`] and/or
[`proxy_add_header_map_value`] with `map_id` set to `HTTP_RESPONSE_HEADERS`.

Paused HTTP requests can be resumed using [`proxy_continue_stream`]
or closed using [`proxy_close_stream`] with `stream_type` set to
Expand Down Expand Up @@ -1125,9 +1107,8 @@ All `num_trailers` trailers can be retrieved and/or modified using
with `map_id` set to `HTTP_RESPONSE_TRAILERS`.

Individual trailers can be retrieved and/or modified using
[`proxy_get_header_map_value`], [`proxy_replace_header_map_value`],
[`proxy_add_header_map_value`] and/or [`proxy_remove_header_map_value`]
with `map_id` set to `HTTP_RESPONSE_TRAILERS`.
[`proxy_get_header_map_value`], [`proxy_replace_header_map_value`] and/or
[`proxy_add_header_map_value`] with `map_id` set to `HTTP_RESPONSE_TRAILERS`.

Paused HTTP requests can be resumed using [`proxy_continue_stream`]
or closed using [`proxy_close_stream`] with `stream_type` set to
Expand Down Expand Up @@ -2129,7 +2110,6 @@ changes to unrelated connections/requests.
[`proxy_get_header_map_value`]: #proxy_get_header_map_value
[`proxy_add_header_map_value`]: #proxy_add_header_map_value
[`proxy_replace_header_map_value`]: #proxy_replace_header_map_value
[`proxy_remove_header_map_value`]: #proxy_remove_header_map_value
[`proxy_continue_stream`]: #proxy_continue_stream
[`proxy_close_stream`]: #proxy_close_stream
[`proxy_on_new_connection`]: #proxy_on_new_connection
Expand Down