-
Notifications
You must be signed in to change notification settings - Fork 4
Fix task auto-completion (#50, #51) #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@copilot please fix prettier errors here |
|
This requires more detailed discussions:
|
|
Oh, and if a spec changes architecture or product definition, the handoff command should make those changes in docs. |
We can "parametrize it", so the command will accept a particular spec for compression, otherwise do compression for all specs if none provided.
If some teammates are working on unfinished specs, they won’t be compressed because there will most likely be unfinished tasks.
I was addressing this issue: #50 The problem is that after we trigger the implement command, it marks checkboxes in tasks files, but always forgets to mark specs and roadmap as finished. Probably I should have split this PR into 2:
We have a very strict set of instructions, that make the whole process less subjective: the LLM must check the checkboxes.
The main reason we mark checkboxes in /awos:implement instead of /awos:handoff comes down to two problems: Problem 1: Roadmap becomes stale If we only mark things in handoff, the roadmap would lie between completing a spec and running handoff. For example, you finish spec 001 on Monday, but the roadmap still shows Feature A as incomplete. You work on other specs for a week. Next Monday you run handoff and only then the roadmap shows Feature A as complete. The roadmap would be out of sync for days or weeks, which defeats its purpose as a source of truth. Problem 2: Handoff is optional Issue #50 specifically asks for automation so users don't forget to mark items. If we put marking in handoff, users might never run it (it's an optional cleanup command) or they can still forget, so issue #50 wouldn't be solved. The current design separates concerns: /awos:implement marks completion immediately when the last task in a spec finishes (solves #50), while /awos:handoff archives already-completed specs into compact summaries (solves #20). The completion check in implement is mechanical, not subjective - it just checks if all checkboxes in tasks.md are marked [x]. It only triggers once per spec when truly complete, so calling implement repeatedly isn't a problem, it just skips the check until the final task. This keeps the roadmap accurate in real-time and makes handoff a true optional milestone cleanup, not a required workflow step.
Good point to consider, but I think this falls outside the scope of handoff. TL:DR I think everything is ok as is. The implement command now is more correct and it makes as completed not only tasks, but also specs and roadmap, making it always up to date and accurate. @workshur share your opinion please once you are back. |
|
Ok, there are more than one conversation now :) Let's start with the flow first.
Hand-off itself, imo, is something where you pass the result of your work with all the documentation. So, probably, it is just a naming crisis:
|
|
@mkf-simpson |
| - Find all acceptance criteria checkboxes (formatted as `- [ ]` within the "Acceptance Criteria" sections). | ||
| - Change all acceptance criteria checkboxes from `[ ]` to `[x]`. | ||
| - Save the updated `functional-spec.md` file. | ||
| - Announce: "All tasks for this spec are complete. I have marked all acceptance criteria in the functional spec as done." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we change the Status of the functional-spec.md as well ? Completed
The status essentially tracks: Draft → In Review → Approved → Completed
Summary
This PR implements automatic completion tracking
Changes
🔧 Fix subtask completion marking (#51)
Problem: The
/awos:implementcommand didn't properly mark nested subtasks when they were completed.Solution: Updated Step 5 in
commands/implement.mdwith explicit instructions:✅ Auto-mark acceptance criteria and roadmap items (#50)
Problem: After completing all tasks in a spec, users had to manually mark acceptance criteria and roadmap items as done, which was easy to forget and caused inconsistency.
Solution: Added new Step 6 to
commands/implement.md:functional-spec.mdas doneroadmap.mdas complete📚 Documentation
/awos:implementdescription to mention auto-completionCloses #50
Closes #51