Skip to content

fix(react): keep table handle menu attached after scrolling - #769

Draft
ocavuebot wants to merge 2 commits into
masterfrom
fix/table-handle-menu-transition
Draft

ocavuebot wants to merge 2 commits into
masterfrom
fix/table-handle-menu-transition

Conversation

@ocavuebot

Copy link
Copy Markdown
Collaborator

The table handle menu is positioned against the trigger inside the handle positioner. That positioner has a transform transition, so while scrolling the menu reads the trigger at a mid-transition position, and nothing repositions it after the transition ends (floating-ui's layout-shift observer is gone once the handle was hidden). This disables the positioner transition while its menu is open, since the handle stays anchored to one cell then anyway.

Written by Claude Opus 5.5.

@vercel

vercel Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
meowdown Ignored Ignored Nov 8, 2026 11:44am UTC

@coderabbitai

coderabbitai Bot commented Nov 8, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown

@pkg-pr-new

pkg-pr-new Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@meowdown/core@769
npm i https://pkg.pr.new/@meowdown/embed@769
npm i https://pkg.pr.new/@meowdown/markdown@769
npm i https://pkg.pr.new/@meowdown/react@769

commit: 24ad9f1

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 93.24% 6607 / 7086
🔵 Statements 92% 8092 / 8795
🔵 Functions 89.69% 1462 / 1630
🔵 Branches 88.33% 5436 / 6154
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/react/src/components/table-handle.module.css 0% 0% 0% 0%
packages/react/src/components/table-handle.module.d.css.ts 0% 0% 0% 0%
Generated in workflow #3017 for commit 24ad9f1 by the Vitest Coverage Report Action

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants