Repository navigation
feat: mark horizontal scrollers with data-scroll-x - #752
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Propagate the horizontal-scroll attribute packages/react/src/components/math-render.tsx, packages/react/src/components/mermaid-render.tsx, packages/react/src/components/code-block-view.tsx, packages/react/src/components/markdown-view.tsx, .changeset/scroll-x-attribute.md |
Math and Mermaid renderers accept and forward data-scroll-x. Code-block, math, and Mermaid previews receive the attribute in both rendering paths. The changeset records a patch release for @meowdown/react. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Feature
Merge Risk: 
Minimal · up to 6b309
-
The intended previews can be selected with data-scroll-x without adding the attribute to copied HTML. No actionable merge-blocking risk was identified.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passedFull details: Docstring Coverage
-
Explanation
Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 5 functions across 4 files. (1 skipped: 1 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
commit: |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Code blocks and math and Mermaid previews scroll horizontally on their own. They now carry a stable
data-scroll-xattribute in the editor and the read-onlyMarkdownView, so a host page can select them without test IDs or hashed CSS module classes. For example, a host whose content only pans vertically can give[data-scroll-x]backtouch-action: auto. The coretoDOMleaves it out, so copied HTML stays clean.Summary by CodeRabbit