This repository was archived by the owner on Aug 13, 2019. It is now read-only.
refactor: reuse the slice in MemPostings.Delete() - #676
Open
YaoZengzeng wants to merge 1 commit into
Open
Conversation
Signed-off-by: YaoZengzeng <yaozengzeng@zju.edu.cn>
bwplotka
approved these changes
Aug 8, 2019
bwplotka
left a comment
Contributor
There was a problem hiding this comment.
I think I like this.
The
found := false
for _, id := range p.m[n][l] {
if _, ok := deleted[id]; ok {
found = true
break
}
}
if !found {
p.mtx.Unlock()
continue
}
Was a quick path to not allocate new slice. Since we reuse slice we don't need to worry about that.
We can drop this since not matter if found or not we would do full loop over p.m[n][l]. In fact in old code we do it twice.
LGTM from my side, thank you for that!
Wonder if we can do some benchmarks for this to actually see the difference? In theory it should be faster.
Contributor
|
Automated tsdb bench tests triggered from a comment coming soon(probably next week) so this would a good test for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YaoZengzeng yaozengzeng@zju.edu.cn