functional test cases#120
Open
kirtisagarksj wants to merge 4 commits into
Open
Conversation
manzarul
reviewed
Oct 19, 2018
| "errmsg": "Role of the user is required" | ||
| "err": "INVALID_USER_DATA", | ||
| "status": "INVALID_USER_DATA", | ||
| "errmsg": "Given User Data doesn't exist in our records. Please provide a valid one" |
Contributor
There was a problem hiding this comment.
@kirtisagarksj this test is for empty role , so it should throw role error.
manzarul
reviewed
Oct 19, 2018
| public void testDeleteUserNoteFailureWithInvalidNoteId() { | ||
| getTestCase().setName(TEST_DELETE_USER_NOTE_FAILURE_WITH_INVALID_NOTEID); | ||
| beforeTest(); | ||
| //beforeTest(); |
Contributor
There was a problem hiding this comment.
why beforeTest(); is commented.
Contributor
Author
|
beforeTest() is commented because the test is for Invalid NoteId. So we
don`t need to call beforeTest to get note id
…On Fri, Oct 19, 2018 at 5:05 PM manzarul Haque ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
sunbird_service_api_test/src/test/java/org/sunbird/integration/test/user/notes/DeleteUserNoteTest.java
<#120 (comment)>
:
> @@ -80,7 +80,7 @@ public void testDeleteUserNoteSuccess(
@citrustest
public void testDeleteUserNoteFailureWithInvalidNoteId() {
getTestCase().setName(TEST_DELETE_USER_NOTE_FAILURE_WITH_INVALID_NOTEID);
- beforeTest();
+ //beforeTest();
why beforeTest(); is commented.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#120 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AomXLrsqPaNaEVInPOPGVaUjdyh-vlr0ks5umbj9gaJpZM4XuT4W>
.
|
manzarul
reviewed
Oct 22, 2018
| @Test(dataProvider = "addUserToOrgFailureDataProvider") | ||
| @CitrusParameters({"testName"}) | ||
| @Test(dataProvider = "addUserToOrgDataProvider") | ||
| @CitrusParameters({"testName", "getUserId", "httpStatus"}) |
Contributor
There was a problem hiding this comment.
getUserId is used for which purpose
manzarul
reviewed
Oct 22, 2018
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "request": { | |||
| "organisationId": "${organisationId}", | |||
Contributor
There was a problem hiding this comment.
Why we always send "organisationId": "${organisationId}" is added in request.
manzarul
reviewed
Oct 22, 2018
| @@ -5,10 +5,10 @@ | |||
| "params": { | |||
Contributor
There was a problem hiding this comment.
Why user not found will be internal error.
|
|
||
| public class AddUserToOrgTest extends BaseCitrusTestRunner { | ||
|
|
||
| public static final String TEST_ADD_USER_TO_ORG_FAILURE_WITH_EMPTY_ROLE_ARRAY = |
Contributor
There was a problem hiding this comment.
Constant name and value don't correspond.
| @CitrusParameters({"testName", "getUserId", "httpStatus"}) | ||
| @CitrusTest | ||
| public void testAddUserToOrgFailure(String testName) { | ||
| public void testAddUserToOrgFailure(String testName, boolean getUserId, HttpStatus httpStatus) { |
Contributor
There was a problem hiding this comment.
Test name and data provider name mismatch.
| return new Object[][] { | ||
| new Object[] {TEST_BLOCK_USER_FAILURE_WITHOUT_ACCESS_TOKEN, false, HttpStatus.UNAUTHORIZED}, | ||
| new Object[] {TEST_BLOCK_USER_FAILURE_WITH_INVALID_USERID, true, HttpStatus.NOT_FOUND}, | ||
| new Object[] {TEST_BLOCK_USER_FAILURE_WITH_INVALID_USERID, true, HttpStatus.INTERNAL_SERVER_ERROR}, |
Contributor
There was a problem hiding this comment.
Why does invalid user ID result in internal server error?
|
|
||
| private void blockUser() { | ||
| UserUtil.blockUser(this, TEMPLATE_DIR_BLOCK, TEST_BA_BLOCK_USER_SUCCESS_WITH_VALID_USERID); | ||
| UserUtil.blockUser(this, TEMPLATE_DIR, "testGetUserByUserIdFailureWithBlockedUser"); |
Contributor
There was a problem hiding this comment.
Why failure request templates passed to block user method?
| return new Object[][] { | ||
| new Object[] {TEST_UNBLOCK_USER_FAILURE_WITHOUT_ACCESS_TOKEN, false, HttpStatus.UNAUTHORIZED}, | ||
| new Object[] {TEST_UNBLOCK_USER_FAILURE_WITH_INVALID_USERID, true, HttpStatus.NOT_FOUND}, | ||
| new Object[] {TEST_UNBLOCK_USER_FAILURE_WITH_INVALID_USERID, true, HttpStatus.INTERNAL_SERVER_ERROR}, |
Contributor
There was a problem hiding this comment.
Why does invalid user ID result in internal server error?
|
|
||
| return new Object[][] { | ||
| new Object[] {TEST_UNBLOCK_USER_SUCCESS_WITH_VALID_USERID, true, HttpStatus.OK}, | ||
| new Object[] {TEST_UNBLOCK_USER_SUCCESS_WITH_VALID_USERID, true, HttpStatus.INTERNAL_SERVER_ERROR}, |
Contributor
There was a problem hiding this comment.
Why does success test result in internal server error?
| new Object[] {TEST_UPDATE_USER_LOGIN_TIME_SUCCESS_WITH_INVALID_USER_ID, true, HttpStatus.OK}, | ||
| }; | ||
| } | ||
| return new Object[][]{ |
Contributor
There was a problem hiding this comment.
Format code properly.
| }, | ||
| new Object[] { | ||
| TEST_UPDATE_USER_PROFILE_VISIBILITY_FAILURE_WITH_INVALID_USERID, true, HttpStatus.NOT_FOUND | ||
| TEST_UPDATE_USER_PROFILE_VISIBILITY_FAILURE_WITH_INVALID_USERID, true, HttpStatus.BAD_REQUEST, false |
Contributor
There was a problem hiding this comment.
Why does invalid user ID result in bad request? Not found is more relevant.
| "err":"MANDATORY_PARAMETER_MISSING", | ||
| "status":"MANDATORY_PARAMETER_MISSING", | ||
| "errmsg":"Mandatory parameter filters is missing." | ||
| ======= |
Contributor
There was a problem hiding this comment.
Unresolved merge conflict is being pushed !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.