feat(deploy-fly): implement real CLI-backed flyctl integration#228
Open
emil07770 wants to merge 1 commit into
Open
feat(deploy-fly): implement real CLI-backed flyctl integration#228emil07770 wants to merge 1 commit into
emil07770 wants to merge 1 commit into
Conversation
Replace stub with actual exec() calls to flyctl for both build and ship.
- build(): runs `flyctl deploy --build-only` with FLY_API_TOKEN env
- ship(): runs `flyctl deploy --remote-only --strategy=<strategy>` with token
- Reads token via ctx.secret('FLY_API_TOKEN'), throws if missing
- Short-circuits on ctx.dryRun in ship()
- Parses deployed URL from flyctl stdout (https://*.fly.dev)
- Passes cwd and env to exec for proper isolation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Heads up — the failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build()andship()with realexec()calls toflyctlbuild(): runsflyctl deploy --build-only --app <app>withFLY_API_TOKENenv varship(): runsflyctl deploy --remote-only --strategy=<strategy> --app <app>with token; supports--regionflags and custom--dockerfilectx.secret('FLY_API_TOKEN'), throws descriptive error if missingctx.dryRuninship()https://*.fly.dev) and deployment version (v<n> deployed)cwd: ctx.projectDirandenv: { FLY_API_TOKEN }toexecfor proper isolationTest plan
FLY_API_TOKENsecret:sh1pt secret set FLY_API_TOKEN <token>sh1pt ship deploy-fly --dry-runshould return{ id: 'dry-run' }without calling flyctlsh1pt build deploy-flyshould invokeflyctl deploy --build-onlysh1pt ship deploy-flyshould invokeflyctl deploy --remote-only --strategy=rollingand return{ id, url }sh1pt secret set FLY_API_TOKEN🤖 Generated with Claude Code