Accept launch parameters as arguments to forward kernel#36
Merged
horizon-blue merged 2 commits intomasterfrom Dec 9, 2025
Merged
Accept launch parameters as arguments to forward kernel#36horizon-blue merged 2 commits intomasterfrom
horizon-blue merged 2 commits intomasterfrom
Conversation
horizon-blue
commented
Dec 9, 2025
| set(CMAKE_EXPORT_COMPILE_COMMANDS ON) | ||
|
|
||
| set(CMAKE_CUDA_FLAGS "${CMAKE_CUDA_FLAGS} -Wno-deprecated-gpu-targets") | ||
| set(CMAKE_CUDA_FLAGS_RELEASE "${CMAKE_CUDA_FLAGS_RELEASE} -Xptxas -O3") |
Contributor
Author
There was a problem hiding this comment.
I'm adding the -Xptxas -O3 flag because in the past it's been giving me better performance... If you're running into build issue, you might need to clear out the build cache once (or also feel free to delete this)
f6fc293 to
3ff5ed5
Compare
3ff5ed5 to
d146664
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that we can tune them on the fly...
Usage:
e.g. For 256x256 image on 5090 (the timing isn't really meaningful here other than showing that this works)