Conversation
MET-31 Implement `Image`
Definition of done:
|
arijit-dasgupta
approved these changes
Nov 30, 2025
Contributor
arijit-dasgupta
left a comment
There was a problem hiding this comment.
LGTM! I did not do too much of a deep dive, want to let you merge this asap. The tests look good and make sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes MET-31.
Summary of Changes
This PR adds
ImageandImageViewclasses:Imageis a host-side-only object that allocate & deallocate the memory buffers in device/host automatically via RAII.ImageViewis a non-owning view ofImagewhich can be copy & pass around on either device or host (or between them).I've added the basic Python bindings for both classes on both device types as well.
Test Plan
The cpp test (
test_image.cu) illustrates how the two classes are expected to be used, checks that we can modify the underlying image buffer throughImageView, and shows that we can copyImagefrom device to host.The python test (
test_image.py) is pretty minimal at this point. It only checks that the bindings are created successfully, and that we can get theconfidenceanddepthfields as 2D JAX arrays. This interface can be used to plot & visualize the image data as we start putting things together.As always, you can run the included tests with
pixi run test