Skip to content

Fix ConfigSelection #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xivh wants to merge 2 commits into
base: 2.X
Choose a base branch
from
Open

Fix ConfigSelection #27

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aaa6e1c
fix selection
xivh May 9, 2026
99ccc28
fix return type
xivh May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions casm/project/enum/_ConfigSelection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,7 +734,7 @@ def calculated_structure_with_properties(self) -> Optional[xtal.Structure]:
"""
calc_dir = self.calc_dir
if calc_dir is None:
return False
return None

structure_file = calc_dir / "structure_with_properties.json"
if not structure_file.exists():
Expand Down Expand Up @@ -1314,7 +1314,7 @@ def select(self, name: str):
"""
record = self.get(name)
if record is not None:
record.selected = True
record.set_selected(True)
else:
raise ValueError(f"Configuration '{name}' not found in selection.")

Expand Down Expand Up @@ -1371,7 +1371,7 @@ def deselect(self, name: str):
"""
record = self.get(name)
if record is not None:
record.selected = False
record.set_selected(False)
else:
raise ValueError(f"Configuration '{name}' not found in selection.")

Expand Down
Loading