Skip to content

Fix CRIT error - #9

Open
DoobleD wants to merge 3 commits into
postalsys:masterfrom
DoobleD:master
Open

Fix CRIT error#9
DoobleD wants to merge 3 commits into
postalsys:masterfrom
DoobleD:master

Conversation

@DoobleD

@DoobleD DoobleD commented Jun 16, 2026

Copy link
Copy Markdown

Fixes:

2026-06-16 22:43:41.462982093  [CRIT] [771F4228-0349-46E9-AE68-470F2D38DF29.1] [core] Plugin mailauth failed: TypeError: params[0].address is not a function
2026-06-16 22:43:42.391401555  [CRIT] [-] [core] Error: Cannot pipe while currently piping
2026-06-16 22:43:42.393596355  [CRIT] [-] [core]     at MessageStream.pipe (/path/to/Haraka/node_modules/haraka-message-stream/index.js:218:29)
2026-06-16 22:43:42.393620305  [CRIT] [-] [core]     at /path/to/Haraka/node_modules/haraka-plugin-clamd/index.js:276:28
2026-06-16 22:43:42.393623176  [CRIT] [-] [core]     at afterWrite (node:internal/streams/writable:708:5)
2026-06-16 22:43:42.393625476  [CRIT] [-] [core]     at afterWriteTick (node:internal/streams/writable:694:10)
2026-06-16 22:43:42.393627896  [CRIT] [-] [core]     at process.processTicksAndRejections (node:internal/process/task_queues:89:21)

And:

[ERROR] [08B64328-1471-4275-97BC-1500E3A5D482.1] [mailauth] TypeError: Cannot set properties of undefined (setting 'dkim')

Provided by Claude.

github-actions Bot and others added 2 commits October 2, 2024 16:57
…method

* **hook_data_post:** guard against missing `txn.notes.mailauth` when `hook_mail` was not called
@CLAassistant

CLAassistant commented Jun 16, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@DoobleD

DoobleD commented Jun 17, 2026

Copy link
Copy Markdown
Author

@msimerson I'm unsure whether the PR should be made here or in https://github.com/haraka/haraka-plugin-mailauth.

@msimerson

Copy link
Copy Markdown
Contributor

I'm not sure either. I've got a PR open here against this repo but maintenance appears to be thin.

@DoobleD

DoobleD commented Jun 17, 2026

Copy link
Copy Markdown
Author

@msimerson I'm unsure whether the PR should be made here or in https://github.com/haraka/haraka-plugin-mailauth.

Oh right, I had not seen your PR fixing the .address() call.

I opened the same PR on https://github.com/haraka/haraka-plugin-mailauth, since you probably have control over that one. The fork will start diverging, but I don't see a better option. 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants