Fix CRIT error - #9
Open
DoobleD wants to merge 3 commits into
Open
Conversation
…method * **hook_data_post:** guard against missing `txn.notes.mailauth` when `hook_mail` was not called
Author
|
@msimerson I'm unsure whether the PR should be made here or in https://github.com/haraka/haraka-plugin-mailauth. |
Contributor
|
I'm not sure either. I've got a PR open here against this repo but maintenance appears to be thin. |
Author
Oh right, I had not seen your PR fixing the .address() call. I opened the same PR on https://github.com/haraka/haraka-plugin-mailauth, since you probably have control over that one. The fork will start diverging, but I don't see a better option. 🤷♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
And:
Provided by Claude.