Skip to content

fix: don't reserve space for attach button when upload is disabled #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpsievert merged 3 commits into from
Jun 19, 2026
Merged

fix: don't reserve space for attach button when upload is disabled #257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4928276
fix: don't reserve space for attach button when upload is disabled
cpsievert Jun 19, 2026
edc4b29
chore: update R and Python dist assets
cpsievert Jun 19, 2026
f444628
chore: drop dead textarea CSS from .shiny-chat-input
cpsievert Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/dist/shinychat.css
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions js/dist/shinychat.css.map
View file
Open in desktop

Large diffs are not rendered by default.

18 changes: 6 additions & 12 deletions js/src/chat/chat.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,20 +203,9 @@ shiny-chat-container {
bottom: calc(-1 * var(--_input-padding-bottom));
padding-block: var(--_input-padding-top) var(--_input-padding-bottom);

textarea {
--bs-border-radius: 26px;
resize: none;
padding-right: 36px !important;
padding-left: 36px !important;
max-height: 175px;
&::placeholder {
color: var(--bs-gray-600, #707782) !important;
}
}
.tiptap {
--bs-border-radius: 26px;
padding-right: 36px !important;
padding-left: 36px !important;
max-height: 175px;
overflow-y: auto;
&.is-empty::before {
Expand All @@ -227,13 +216,18 @@ shiny-chat-container {
pointer-events: none;
}
}
// Only reserve left space when the attach button is actually rendered
&:has(.shiny-chat-btn-attach) {
.tiptap {
padding-left: 36px !important;
}
}
Comment thread
cpsievert marked this conversation as resolved.
// When images are attached, group the thumbnail tray and the text field into
// a single bordered, tinted shell so they read as one control.
&:has(.shiny-chat-input-attachments) {
border: 1px solid var(--bs-border-color, #ced4da);
border-radius: 20px;

textarea,
.tiptap {
border-color: transparent !important;
background: transparent !important;
Expand Down
2 changes: 1 addition & 1 deletion pkg-py/src/shinychat/www/GIT_VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1d87b2928bc62de01717ae6d92a59c88c22b8780
edc4b29a636a2dfddfffc41d141644d664830b11
2 changes: 1 addition & 1 deletion pkg-py/src/shinychat/www/shinychat.css
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions pkg-py/src/shinychat/www/shinychat.css.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion pkg-r/inst/lib/shiny/GIT_VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1d87b2928bc62de01717ae6d92a59c88c22b8780
edc4b29a636a2dfddfffc41d141644d664830b11
2 changes: 1 addition & 1 deletion pkg-r/inst/lib/shiny/shinychat.css
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions pkg-r/inst/lib/shiny/shinychat.css.map
View file
Open in desktop

Large diffs are not rendered by default.

Loading