fix: snowflake authenticator matching is case insensitive#772
Open
aronatkins wants to merge 1 commit into
Open
fix: snowflake authenticator matching is case insensitive#772aronatkins wants to merge 1 commit into
aronatkins wants to merge 1 commit into
Conversation
|
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
The
connections.tomlmay have a lower-cased authenticator name.Permit arbitrary case for authenticator names.
fixes #771
Type of Change
Approach
Fetched the authenticator from the parsed connection parameters, ensure that it exists, and lower it before comparing to known authenticator names.
Automated Tests
Added unit tests which confirm support for
SNOWFLAKE_JWTandsnowflake_jwt. Added unit tests confirming the errors produced when no authenticator is defined and when the named authenticator is not supported.Directions for Reviewers
Checklist
rsconnect-python-tests-at-nightworkflow in Connect against this feature branch.