feat: harden ExecuteTransaction verification (#304)#306
Merged
Conversation
- ExecutePendingTransactions now schedules children with bounded concurrency (pLimit) + Promise.allSettled instead of a serial await loop, so one slow tx no longer blocks the rest. Matches the SupplierStatus pattern. - A START_TO_CLOSE verify timeout is now classified as inconclusive (own verifyTimedOut flag + distinct log line) rather than an unexpected verification error, keeping it distinguishable from a genuine not-found. for triage. - getTransactionFromBlock clamps the scan window to the chain head (skips future/never-produced heights) and fetches candidate blocks in parallel with a bounded worker pool (BLOCK_SCAN_CONCURRENCY) to cap the per-scan RPC burst.
3 tasks
Align with the SupplierStatus/SupplierRemediation pattern: tolerate a partial failure (one bad tx must not block the rest) but surface a WorkflowError when every scheduled child failed, so a systemic problem (RPC/DB down) no longer completes green. Guard the empty-batch case where every() over [] would vacuously throw. Also fix the stray unindented results line.
jorgecuesta
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExecutePendingTransactions now schedules children with bounded concurrency (pLimit) + Promise.allSettled instead of a serial await loop, so one slow tx no longer blocks the rest. Matches the SupplierStatus pattern.
A START_TO_CLOSE verify timeout is now classified as inconclusive (own verifyTimedOut flag