feat(middleman): surface rev share split and warn on 0% client share#300
Merged
Merged
Conversation
Stake Review only showed the resulting Client Share %, leaving where the rest of the rewards go implicit. Add explicit Provider, Supplier and Delegator rows alongside Client Share in PlanDetailsSection, and warn in ReviewStep when the client share is 0% or below so a delegator can't unknowingly stake for no rewards.
jorgecuesta
force-pushed
the
feature/rev-share-split-and-warning
branch
from
a2bb635 to
0200222
Compare
jorgecuesta
approved these changes
Jun 5, 2026
Merged
jorgecuesta
pushed a commit
that referenced
this pull request
Jun 5, 2026
* fix: fixing route allow change admin (#295) * fix: mark stake transactions correctly when they land more than one block after broadcast (#278) * feat(middleman): surface rev share split and warn on 0% client share (#300) --------- Co-authored-by: miguel502 <miguelcalderon6@gmail.com> Co-authored-by: Alan Rojas <alan2rm7@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stake Review only showed the resulting Client Share %, leaving where the rest of the rewards go implicit. Add explicit Provider, Supplier and Delegator rows alongside Client Share in PlanDetailsSection, and warn in ReviewStep when the client share is 0% or below so a delegator can't unknowingly stake for no rewards.