Repository navigation
Conversation
|
@cytle is attempting to deploy a commit to the pnpm Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for getpnpm ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Stop both installers before downloading an unavailable or broken pnpm 11 executable. Point users to the exact JavaScript package version or pnpm 12, and preserve supported platform mappings.
Explain the guard in install.sh, list pnpm 12 first in both installers, and link the upstream issue from install.sh as the TypeScript CLI does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zkochan
force-pushed
the
codex/fix-pnpm11-arm64-musl
branch
from
October 10, 2026 18:13
4514e72 to
0f8433a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes pnpm/tasks#49.
Both installers now reject pnpm 11 on Linux ARM64 musl before requesting the executable. They explain that this target has no working binary and suggest either
npm install -g pnpm@<resolved-version>or pnpm 12. pnpm 10, pnpm 12, ARM64 glibc, and x64 musl retain their existing mappings.install.shandget-pnpmpreviously accepted this target, requesting a pnpm 11 artifact that either crashes or is no longer published. The TypeScript CLI and exporteddownloadPnpmExecutableAPI use the same guard. An optionalTarget.versionpreserves exact-version guidance without breaking callers that supply only the major.Validation
get-pnpm:pnpm testpassed (TypeScript compilation and 78 tests, no skips).test/target.sh,test/resolve-version.sh, andtest/shadowing.shpassed undersh,bash, anddashon macOS.bash,dash,ksh, andshdialects;git diff --checkpassed.test/verification.sh install.shcould not finish locally: its registry fixture did not finish starting within its 10-second wait. CI will exercise this separately. No native ARM64 musl binary was run locally.Maintainer action before merge
Changing
install.shmakes its signed checksum stale. A maintainer with the pnpm release key needs to run./_update.shto regenerateSHASUMS256.txtand its signature. These files are left unchanged; the integrity check is expected to fail until they are re-signed, as documented by the repository's npm-key-rotation workflow.Written by an agent (Codex, GPT-6).