Skip to content

fix: reject pnpm 11 on arm64 musl Linux - #65

Draft
cytle wants to merge 2 commits into
pnpm:mainfrom
cytle:codex/fix-pnpm11-arm64-musl
Draft

cytle wants to merge 2 commits into
pnpm:mainfrom
cytle:codex/fix-pnpm11-arm64-musl

Conversation

@cytle

@cytle cytle commented Sep 28, 2026

Copy link
Copy Markdown

Closes pnpm/tasks#49.

Both installers now reject pnpm 11 on Linux ARM64 musl before requesting the executable. They explain that this target has no working binary and suggest either npm install -g pnpm@<resolved-version> or pnpm 12. pnpm 10, pnpm 12, ARM64 glibc, and x64 musl retain their existing mappings.

install.sh and get-pnpm previously accepted this target, requesting a pnpm 11 artifact that either crashes or is no longer published. The TypeScript CLI and exported downloadPnpmExecutable API use the same guard. An optional Target.version preserves exact-version guidance without breaking callers that supply only the major.

Validation

  • Regression tests failed before the fix and pass after it. They simulate the host platform and assert that no executable download is attempted, including for pnpm 11 prereleases.
  • get-pnpm: pnpm test passed (TypeScript compilation and 78 tests, no skips).
  • test/target.sh, test/resolve-version.sh, and test/shadowing.sh passed under sh, bash, and dash on macOS.
  • ShellCheck 0.11.0 passed for the changed Shell files with the bash, dash, ksh, and sh dialects; git diff --check passed.
  • The existing test/verification.sh install.sh could not finish locally: its registry fixture did not finish starting within its 10-second wait. CI will exercise this separately. No native ARM64 musl binary was run locally.

Maintainer action before merge

Changing install.sh makes its signed checksum stale. A maintainer with the pnpm release key needs to run ./_update.sh to regenerate SHASUMS256.txt and its signature. These files are left unchanged; the integrity check is expected to fail until they are re-signed, as documented by the repository's npm-key-rotation workflow.


Written by an agent (Codex, GPT-6).

@vercel

vercel Bot commented Sep 28, 2026

Copy link
Copy Markdown

@cytle is attempting to deploy a commit to the pnpm Team on Vercel.

A member of the Team first needs to authorize it.

@netlify

netlify Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for getpnpm ready!

Name Link
🔨 Latest commit 0f8433a
🔍 Latest deploy log https://app.netlify.com/projects/getpnpm/deploys/6aca8060e1c3c90008c15539
😎 Deploy Preview https://deploy-preview-65--getpnpm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

cytle and others added 2 commits October 10, 2026 20:12
Stop both installers before downloading an unavailable or broken pnpm 11 executable. Point users to the exact JavaScript package version or pnpm 12, and preserve supported platform mappings.
Explain the guard in install.sh, list pnpm 12 first in both installers,
and link the upstream issue from install.sh as the TypeScript CLI does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@zkochan
zkochan force-pushed the codex/fix-pnpm11-arm64-musl branch from 4514e72 to 0f8433a Compare October 10, 2026 18:13

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get.pnpm.io: explain that pnpm 11 has no arm64 musl executable

2 participants