abi: Fix header parser to support multiline function prototypes - #7941
Merged
Conversation
The `maint/gen_abi.py` script had a slightly broken C header parser and code generator. If a function prototype would span multiple lines, the generated code missed the `MPICH_API_PUBLIC` annotation, thus affecting symbol visibility and, ultimately, the exposed symbols in libmpi_abi.so.
Collaborator
Author
|
@hzhou Could you please trigger the ABI tests on your side? |
Collaborator
|
test:mpich/custom |
Collaborator
Author
|
mpi4py ABI tests all OK: https://github.com/mpi4py/mpi4py-testing/actions/runs/32986880856/job/98235284716 |
Collaborator
Author
|
@hzhou This easy one is ready to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
The
maint/gen_abi.pyscript had a slightly broken C header parser and code generator. If a function prototype would span multiple lines, the generated code missed theMPICH_API_PUBLICannotation, thus affecting symbol visibility and, ultimately, the exposed symbols in libmpi_abi.so.Partially addresses some of the concerns raised in #7938.
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.