configure: don't pass compile flags through WRAPPER - #7921
Open
hzhou wants to merge 2 commits into
Open
Conversation
Collaborator
Author
|
test:mpich/ch3/most |
Pass sanitizer ldflags to WRAPPER_LDFLAGS so the user program won't fail with "ASan runtime does not come first in initial library list".
We no longer use @cflags@ etc in mpicc.
hzhou
force-pushed
the
2608_wrapper_flags
branch
from
August 5, 2026 02:54
8f99d59 to
bd13e86
Compare
Collaborator
Author
|
test:mpich/ch3/most |
Collaborator
|
Correct me if I'm wrong (this comment is generated with the help of AI): This fixes the immediate leakage of |
Collaborator
Author
|
@Growl1234 Thanks for the good catch! You are right. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
PAC_PREFIX_FLAGpreviously copied user's flags (e.g.CFLAGS) intoWRAPPER_CFLAGS, causingmpiccto pass them to user applications. WRAPPER compile flags should only contain flags explicitly needed by applications, not MPICH's own build flags.PAC_PREFIX_FLAGto initialize prefixed variables to empty-g, sanitizer, and coverage flag appends to WRAPPER flagsWRAPPER_LIBSis unaffected and continues to pass needed librariestag @Growl1234
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.