Skip to content

DOC: Update PyPDF2 links / mentions #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MartinThoma wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DOC: Update PyPDF2 links / mentions #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,9 +686,9 @@ Pure Python
reportlab is must-have software if you want to programmatically
generate arbitrary PDFs.

- `pyPdf <https://github.com/mstamy2/PyPDF2>`__
- `pypdf <https://pypi.org/project/pypdf/>`__

pyPdf is, in some ways, very full-featured. It can do decompression
pypdf is, in some ways, very full-featured. It can do decompression
and decryption and seems to know a lot about items inside at least
some kinds of PDF files. In comparison, pdfrw knows less about
specific PDF file features (such as metadata), but focuses on trying
Expand Down
2 changes: 1 addition & 1 deletion pdfrw/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

__version__ = '0.4'

# Add a tiny bit of compatibility to pyPdf
# Add a tiny bit of compatibility to pyPdf / PyPDF2<1.28.0

PdfFileReader = PdfReader
PdfFileWriter = PdfWriter
Expand Down
2 changes: 1 addition & 1 deletion pdfrw/pdfreader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,7 +680,7 @@ def __init__(self, fname=None, fdata=None, decompress=False,
if decompress:
self.uncompress()

# For compatibility with pyPdf
# For compatibility with pyPdf / PyPDF2<1.28.0
private.numPages = len(self.pages)
finally:
if disable_gc:
Expand Down
2 changes: 1 addition & 1 deletion pdfrw/pdfwriter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ def addpage(self, page):
new_obj = None
return self

addPage = addpage # for compatibility with pyPdf
addPage = addpage # for compatibility with pyPdf / PyPDF2<1.28.0

def addpages(self, pagelist):
for page in pagelist:
Expand Down