Skip to content

Fix dynamic properties and png rendering deprecations#279

Merged
Rom1-B merged 7 commits into
pluginsGLPI:mainfrom
Vireth4114:fix_png
Jul 31, 2025
Merged

Fix dynamic properties and png rendering deprecations#279
Rom1-B merged 7 commits into
pluginsGLPI:mainfrom
Vireth4114:fix_png

Conversation

@Vireth4114

Copy link
Copy Markdown
Contributor

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes # (issue number, if applicable)
    closes Fixes deprecated dynamic property in baseclass.class.php and helpdeskplus.class.php #273 (most of the deprecated fields were fixed beforehand, but close_date, slaok and slako weren't).
  • Here is a brief description of what this PR does
    • Fixes a few dynamic property deprecation
    • Fixes strftime deprecations
    • Fixes png related deprecations (most are float to int implicit conversion that was deprecated in php 8.1, and a removed argument in imagefilledpolygon() )

@trasher trasher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, appart my comment.

Comment thread inc/notificationtargetnotification.class.php
@Vireth4114

Copy link
Copy Markdown
Contributor Author

I switched the displayed date in notification target to an IntlDateFormatter to accommodate localization. (And I also used the locale's "from %s to %s" instead of raw "du/au")

@Rom1-B

Rom1-B commented Jul 23, 2025

Copy link
Copy Markdown
Contributor

@Vireth4114,
Please rebase to solve conflicts.

@Rom1-B
Rom1-B merged commit 4525803 into pluginsGLPI:main Jul 31, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fixes deprecated dynamic property in baseclass.class.php and helpdeskplus.class.php

3 participants