[inferno-core] Stop using Set for constraint accumulation, refactor infer a bit - #206
Merged
Merged
Conversation
ngua
marked this pull request as draft
April 6, 2026 09:39
ngua
marked this pull request as ready for review
April 8, 2026 04:06
Set for constraint accumulation, refactor inference function a bitSet for constraint accumulation, refactor inferExpr a bit
Set for constraint accumulation, refactor inferExpr a bitSet for constraint accumulation, refactor infer a bit
…b.com:plow-technologies/inferno into rory-typechecker-stop-using-set-for-no-reason
shulhi
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no reason to use a
Setfor accumulating constraints:Constraintis anEither (InfernoType, InfernoType, [TypeError SourcePos]) (Location SourcePos, TypeClass). EverySetoperation had to compare deeply nested structures (walking entire type trees and error lists with source positions) to maintain orderingpartitionEithers, and doesn't depend on uniqueness or orderingConstraints aren't duplicate in practice as they carry a[TypeError SourcePos]with unique source locations. Even if somehow there was a duplicate type constraint, the solver can handle it: after the first unification binds the type variable, the duplicate becomes e.g.Int ~ Intand succeeds (empty substitution)Seqare much better here than aSetSome other changes:
NOTE: Inferno tests pass themselves but need to test this elsewhere too