Repository navigation
fix(release): move initial-version to root config for all packages - #42
Conversation
dosubot
Bot
added
the
size:XS
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the Release Please configuration to standardize the initial versioning strategy across all packages. By elevating the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly adds the initial-version setting to the root of the release-please-config.json to ensure new packages start at version 0.1.0. However, the original package-specific setting was not removed, leading to redundancy. I've added a comment to suggest removing it to complete the intended move and keep the configuration clean.
| "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json", | ||
| "bump-minor-pre-major": true, | ||
| "bump-patch-for-minor-pre-major": true, | ||
| "initial-version": "0.1.0", |
There was a problem hiding this comment.
With initial-version now defined at the root, the package-specific entry in apps/work-please has become redundant. To complete the 'move' as described in the PR summary and keep the configuration clean, please remove the initial-version key from the package configuration.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
…efix option Move git worktrees from <repoDir>/.claude/worktrees/ to <workspace.root>/github-<owner>-<repo>/worktrees/ to prevent unstaged changes from blocking before_run hook rebase operations. Also strip leading # from identifiers (#42 → 42 instead of _42) and add workspace.branch_prefix config option for custom branch name prefixes (e.g. agent-please/42).
…efix option (#178) * fix(workspace): move worktree path outside repo dir and add branch prefix option Move git worktrees from <repoDir>/.claude/worktrees/ to <workspace.root>/github-<owner>-<repo>/worktrees/ to prevent unstaged changes from blocking before_run hook rebase operations. Also strip leading # from identifiers (#42 → 42 instead of _42) and add workspace.branch_prefix config option for custom branch name prefixes (e.g. agent-please/42). * test(workspace): fix applyBranchPrefix test and assert worktree path invariant - Fix test that claimed to test empty string but passed null - Add assertion that worktree path uses sanitized identifier (no prefix) * fix(state): fix ioredis adapter function name and state error tests - Fix createIORedisState → createIoRedisState to match actual package export - Mock adapter packages in error tests since they are now installed * fix(workspace): add branch_prefix to workspace config in test fixtures * chore: apply AI code review suggestions - Reuse resolveRepoDir in resolveWorktreePath to reduce duplication - Assert non-error before checking result.path in test
Summary
Move
initial-version: "0.1.0"from theapps/work-pleasepackage-level config to the root config level so it applies globally to all packages.Why
When Release Please encounters a package at
0.0.0(never released), it ignores thebump-patch-for-minor-pre-majorflag and computes1.0.0instead of0.1.0. Settinginitial-version: "0.1.0"at the root ensures the first release starts at0.1.0for any package added in the future, not justapps/work-please.Summary by cubic
Move
initial-version: "0.1.0"to the rootrelease-pleaseconfig so all packages start at 0.1.0 on their first release. This fixes cases where packages at 0.0.0 were computed as 1.0.0 despitebump-patch-for-minor-pre-major.Written for commit bf447c4. Summary will update on new commits.