deploy.yml: preserve sidecar broker + its nginx route on every VM deploy#81
Merged
Merged
Conversation
The on-merge VM deployer rebuilt only publish-server + broker and ran setup-broker-tls.sh WITHOUT broker-extra-locations, so setup-broker-tls.sh regenerated broker.conf with just `location /` and dropped the signup broker's /insforge/signup route on every deploy. Now the deploy step also rebuilds + restarts cmd/insforge-signup-broker (when its unit is installed) and passes the broker-extra-locations metadata to setup-broker-tls.sh so the route is re-injected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the durability fix. The on-merge VM deployer (
deploy.yml) rebuilt onlypublish-server+brokerand calledsetup-broker-tls.shwithoutbroker-extra-locations, so every deploy regeneratedbroker.confwith justlocation /and dropped the signup broker's/insforge/signuproute.cmd/insforge-signup-broker(guarded on its unit being installed).broker-extra-locationsmetadata and passes it tosetup-broker-tls.sh, which re-injects the route.Verified by dispatching
deploy.ymland confirming/insforge/signupsurvives the redeploy.