Repository navigation
Claude/site review improvements bokaj - #2
Merged
Merged
Conversation
P0: - Allow pinch-zoom (drop maximum-scale + user-scalable=no, WCAG 1.4.4) - Sanitize marked output with DOMPurify - Add rel=noopener noreferrer to all target=_blank and window.open calls - Point og:image at existing favicon asset (was 404) - Close two unbalanced <div>s in the dock block P1: - Remove dead tailwind.config.js (Tailwind v4 uses @theme in styles.css) - Sync README font/credits with the actual stack - Trim Google Fonts: drop Noto Sans (use DM Sans + system fallback), drop Outfit weights 400/600/800, drop Rajdhani 400/500 - Lazy-import all games and apps (each becomes its own Vite chunk) - Extract spotlight search to src/spotlight.ts (~170 lines off main.ts) - Augment Window type declarations and fix HTMLElement/HTMLCanvasElement casts - Add tsc --noEmit step to CI; relax tsconfig strict (full strict pass is a separate effort) so existing code still compiles - Deploy job now downloads the dist artifact from CI instead of rebuilding
Pull six self-contained concerns out of the 2.5k-line main.ts: - src/sw-register.ts PWA service-worker registration (~13 lines) - src/clock.ts menubar clock with flip-digit animation (~49 lines) - src/launchpad.ts full-screen app grid + filter (~48 lines) - src/monitor.ts canvas graph + KPI ticker + tab switcher (~119 lines) - src/markdown-viewer.ts fetch+marked+DOMPurify viewer window (~118 lines) - src/theme.ts theme/wallpaper logic incl. setTheme/initTheme (~146 lines) Also fixes the duplicate window.openMarkdownViewer override that was silently shadowing the real fetch+render implementation with a stub. main.ts: 2716 -> 2055 lines (~661 lines extracted across 6 modules). Typecheck, vitest suite, and vite build all green.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.