refactor: rewrite batch processor [ANK-377]#161
Open
piazza-bot wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generateNotesisolated from stale manual UI cancellation.generateNotespreflight note/deck mapping before worker execution and return partial results withOut of creditswhen the worker pool hits capacity.Verification
source .venv/bin/activate && ./scripts/build.sh fixsource .venv/bin/activate && ./scripts/build.sh checksource .venv/bin/activate && python -m pytestsource .venv/bin/activate && ./scripts/build.sh sandbox-local:127.0.0.1:8766.Basicmodel fields, create a temporary note, read it back, and delete it.ping,getSmartFieldsforBasic, andgenerateNoteson the temporary note.{"updated": [], "failed": [], "skipped": [<temp note id>]}with no error.requireReset() is obsolete; please use CollectionOp()warning duringaddNote; Smart Notes requests completed with HTTP 200.get_app_stateattached to/Applications/Anki.appand showed the sandbox Anki deck list.Agent session metadata
/Users/michaelpiazza/conductor/workspaces/smart_notes_all/warsaw/anki-smart-notesb77430b7-3079-4a90-b0a2-ce65f0b1115a