Skip to content

findQueryInRow: accept Worksheet instead of String for searchWorksheet#26

Merged
physics515 merged 3 commits into
mainfrom
copilot/find-query-in-row-accept-worksheet-type
Jun 4, 2026
Merged

findQueryInRow: accept Worksheet instead of String for searchWorksheet#26
physics515 merged 3 commits into
mainfrom
copilot/find-query-in-row-accept-worksheet-type

Conversation

Copilot AI commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

findQueryInRow required callers to pass a worksheet name as a String, forcing an internal wb.Sheets() lookup. The parameter now accepts a Worksheet object directly, consistent with how other functions in the library (e.g. fuzzyFind) handle worksheet arguments.

Changes

Before / After

' Before
findQueryInRow("Sheet1", "foo", "1:1")

' After
findQueryInRow(Sheet1, "foo", "1:1")

Copilot AI changed the title [WIP] Update Search Sheet input to accept Worksheet type findQueryInRow: accept Worksheet instead of String for searchWorksheet Jun 3, 2026
Copilot AI requested a review from physics515 June 3, 2026 17:27
@physics515

Copy link
Copy Markdown
Owner

@copilot resolve the merge conflicts in this pull request

…-row-accept-worksheet-type

# Conflicts:
#	README.md
#	findQueryInRow.bas

Copilot AI commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

Merge conflicts resolved. The conflict in findQueryInRow.bas was between our searchRow As String and main's searchRow As Range (from a separately merged PR #27); main's Range type was kept. The README conflict was just the example text for the worksheet parameter, also resolved to match main's style.

@physics515 physics515 marked this pull request as ready for review June 4, 2026 14:06
Copilot AI review requested due to automatic review settings June 4, 2026 14:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@physics515 physics515 merged commit 7cf609e into main Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Find Query In Row - Should Accept Type of Worksheet for Seach Worksheet

3 participants