fix(computer-win): screenshot --display no longer requires a pid#952
Merged
Conversation
The Windows helper's screenshot handler demanded an int `pid` param unconditionally (Screenshot.cs), so a full-display capture — which needs no target app, mirroring the macOS `screenshot --display` path — failed with `invalid_params: missing int param: pid`. Surfaced by the Windows-host e2e suite (#864) the moment it ran in CI: 'screenshot --host returns a non-empty PNG over the tunnel'. pid is now optional. With a pid, --display still captures the monitor that pid's window sits on; without one it captures the primary screen. list and window-capture modes still require pid (enforced once the mode is known). Verified end-to-end against a live win-mini over the ssh -L tunnel: the full ssh-tunnel.e2e.test.ts suite now passes 4/4 (was 3/4, this test failing).
muqsitnawaz
force-pushed
the
fix-win-screenshot-display
branch
from
July 13, 2026 07:34
c0449ae to
33a9136
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug (surfaced by #864's e2e suite)
The moment the Windows-host e2e suite ran in CI (wired up in #864), it caught a real bug:
Screenshot.Capture(native/computer-win/Screenshot.cs) parsedpidwithP.Int(@params, "pid")unconditionally, before dispatching on mode. But a full-display capture (display: true) needs no target app — it mirrors the macOSscreenshot --displaywhole-screen path. Soagents computer screenshot --display(no app) always failed on Windows.The fix
pidis now optional:display: truewith a pid → capture the monitor that pid's window sits on (unchanged behavior).display: truewithout a pid → capture the primary screen.listand window-capture modes still requirepid, enforced once the mode is known (missing int param: pid).Verification (real, end-to-end)
Cross-built the win-x64 helper with the fix (
scripts/build-win.sh, dotnet 10), and ran the full computer e2e suite against a live win-mini over the realssh -Ltunnel from zion:The
screenshot --hosttest now returns a valid PNG (magic89 50 4E 47, >1KB) over the tunnel.Refs #864 (this is the first real bug the e2e suite caught; it takes the suite's CI run from 4/5 to 5/5 green).