fix: prevent sibling shim daemon crash loops#881
Merged
Conversation
Contributor
Author
|
Exact installed-artifact verification on mac-mini (head This is the real installed |
Contributor
Author
|
Independent fallback review completed after the configured reviewer did not post:
|
Contributor
Author
|
Post-merge installed-main verification ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Fixes RUSH-1527 by ensuring daemon auto-starts from the installed
browserandcomputersibling shims invoke the canonicalagents daemon _runentrypoint instead of recursively invoking a shim that does not implementdaemon.Headless daemon startup now reads only the already-unlocked secrets-agent snapshot. It does not trigger an unanswerable Keychain biometric prompt when no TTY is present.
This replaces #878, rebased cleanly onto the current default branch after #876 merged.
Verification
bun run buildbunx vitest run src/lib/daemon.test.ts src/lib/secrets/bundles.test.tsUser-visible documentation
Session evidence
Public repository: transcript intentionally omitted. Fleet-local transcript:
zion:/Users/muqsit/.codex/sessions/2026/07/10/rollout-2026-07-10T16-41-07-019f4e68-044c-7872-977c-0f748562dc06.jsonl.