refactor: adjust to use direct dictionaries rather than paths#4
Closed
phalberg wants to merge 2 commits into
Closed
refactor: adjust to use direct dictionaries rather than paths#4phalberg wants to merge 2 commits into
phalberg wants to merge 2 commits into
Conversation
Owner
phalberg
commented
Jun 1, 2026
phalberg
commented
- Bad practice to use file_paths
- A dictionary should be given directly instead
- the change should not be so big (but test cases must adhere and change for it)
phalberg
added
enhancement
phalberg
deleted the
refactor/adjust_to_use_files_directly_rather_than_paths
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.