Update typingQC to align with mikrokondo and CDC #21
Draft
kylacochrane wants to merge 15 commits into
Draft
Conversation
Updating the template for TypingQC pipeline
Initial Release of TypingQC v1.0.0
Update to Version 1.0.1
1.0.2 Release
…_count quality metric
…puts for formatting improvement
This PR is against the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates to three typingQC pipeline modules to support a new mikrokondo QA field, fix a pre-existing schema mismatch, and add serovar nomenclature handling.
sequenceQC.py
wgmlst_loci_countto QA handling: captured as a warning test but returnsPNC_FAIL_MESSAGEon failureCHECKM_TESTconstant:checkm_contamination→checkm2_contaminationto match current mikrokondo JSON schemasistrQC.py
INFO: Number of cgMLST loci foundmessage fromqc_messagesbefore reportingquality_metricsreports a warning instead of a raw FAIL messagevalidateSerotype.py
Panama→Panama/Houston,Sendai→Miamiquality_metricsPR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).