Skip to content

refactor(tokens): align Tooltip and DataGrid roles#119

Merged
ksierks merged 2 commits into
mainfrom
refactor/tooltip-data-grid-token-hygiene
Jul 13, 2026
Merged

refactor(tokens): align Tooltip and DataGrid roles#119
ksierks merged 2 commits into
mainfrom
refactor/tooltip-data-grid-token-hygiene

Conversation

@joshsadam

@joshsadam joshsadam commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

What does this PR do and why?

  • Replaces Tooltip and DataGrid hard-coded shadow, radius, and duration values with shared --pvc-* role tokens.
  • Updates the token status table to match the component code.

Closes #93.

Screenshots or screen recordings

  • N/A (Lookbook preview layout refresh; verify Tooltip previews in light and dark mode)

How to set up and validate locally

  1. direnv allow and bin/setup if needed
  2. bin/test test/components/pathogen/tooltip_test.rb test/components/pathogen/data_grid_component_test.rb
  3. pnpm test -- test/javascript/controllers/tooltip_controller.test.js
  4. pnpm run build:css:check

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Copilot AI review requested due to automatic review settings July 10, 2026 22:45

This comment was marked as resolved.

@joshsadam joshsadam self-assigned this Jul 10, 2026
@joshsadam joshsadam requested a review from ksierks July 10, 2026 22:50
@joshsadam joshsadam changed the title refactor(tooltip): token hygiene and preview cleanup refactor(tokens): align Tooltip and DataGrid roles Jul 11, 2026
Comment thread app/components/pathogen/tooltip.rb
@joshsadam joshsadam force-pushed the refactor/tooltip-data-grid-token-hygiene branch from 5e3d689 to 3bf9ef4 Compare July 13, 2026 14:26
@joshsadam joshsadam force-pushed the refactor/tooltip-data-grid-token-hygiene branch from 3bf9ef4 to 6077952 Compare July 13, 2026 15:04
@ksierks ksierks merged commit d8ede6d into main Jul 13, 2026
3 checks passed
@ksierks ksierks deleted the refactor/tooltip-data-grid-token-hygiene branch July 13, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(tokens): clean up Tooltip and DataGrid token hygiene

3 participants