Skip to content

Codacy security and code quality findings - #11

Merged
mason-sharp merged 2 commits into
mainfrom
fix/SPOC-472/codacy-202604
Apr 15, 2026
Merged

Codacy security and code quality findings#11
mason-sharp merged 2 commits into
mainfrom
fix/SPOC-472/codacy-202604

Conversation

@mason-sharp

@mason-sharp mason-sharp commented Apr 10, 2026

Copy link
Copy Markdown
Member
  • Update Go 1.23.0 to 1.25.8 and pgx/v5 5.5.0 to 5.9.1, resolving
    multiple CVEs in stdlib, x/crypto, and pgx
  • Pin third-party GitHub Actions (codecov, goreleaser) to commit SHAs

Test plan

  • All existing unit tests pass (make test)
  • Linter passes (make lint)
  • Build succeeds (make build)
  • Verify Codacy re-scan shows resolved findings

Update Go 1.23.0 to 1.25.8, pgx/v5 5.5.0 to 5.9.1, and transitive
dependencies (x/crypto, x/net, x/sync, x/sys, x/text) to resolve
CVEs. Pin codecov-action and goreleaser-action to commit SHAs.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@codacy-production

codacy-production Bot commented Apr 10, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 duplication

Metric Results
Duplication 0

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@coderabbitai

coderabbitai Bot commented Apr 10, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

This pull request updates Go tooling and dependencies across build configuration and source code. The workflow configurations pin two GitHub Actions to specific commit SHAs instead of floating version tags. The Go version matrix in the CI workflow is reduced to test against a single Go runtime version. The project's Go toolchain requirement is bumped from version 1.23.0 to 1.25.8, and direct and indirect dependencies are updated, including PostgreSQL-related packages and standard library extensions.

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 70.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'Codacy security and code quality findings' is vague and does not clearly convey the main changes: Go/dependency updates and GitHub Actions pinning for security. Consider a more specific title like 'Update Go to 1.25.8 and pgx to 5.9.1, pin GitHub Actions for security' to clearly communicate the primary changes.
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly relates to the changeset, detailing Go and pgx version updates to resolve CVEs, GitHub Actions pinning, and a comprehensive test plan.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/SPOC-472/codacy-202604

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]

This comment was marked as outdated.

@mason-sharp
mason-sharp force-pushed the fix/SPOC-472/codacy-202604 branch from de3d5b1 to aa3c564 Compare April 14, 2026 18:39
Go 1.23 and 1.24 are incompatible with go.mod requiring 1.25.8,
and stdlib CVE fixes are only available in 1.25+.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)

40-41: Good SHA pinning; optional cleanup: remove now-redundant if.

Pinning codecov/codecov-action to a commit SHA is a solid security improvement. Since the matrix only has '1.25', the condition on Line 40 is always true and can be removed for clarity.

Optional simplification
-            - name: Upload coverage
-              if: matrix.go-version == '1.25'
+            - name: Upload coverage
               uses: codecov/codecov-action@b9fd7d16f6d7d1b5d2bec1a2887e65ceed900238 # v4
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/ci.yml around lines 40 - 41, The workflow contains a
redundant conditional "if: matrix.go-version == '1.25'" guarding the "uses:
codecov/codecov-action@b9fd7d16f6d7d1b5d2bec1a2887e65ceed900238" step; remove
that "if" line so the codecov action runs unconditionally in this job and keep
the SHA-pinned action reference as-is (locate the lines containing the "if:
matrix.go-version" and "uses: codecov/codecov-action@b9fd7d16..." entries to
make the edit).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.github/workflows/ci.yml:
- Around line 40-41: The workflow contains a redundant conditional "if:
matrix.go-version == '1.25'" guarding the "uses:
codecov/codecov-action@b9fd7d16f6d7d1b5d2bec1a2887e65ceed900238" step; remove
that "if" line so the codecov action runs unconditionally in this job and keep
the SHA-pinned action reference as-is (locate the lines containing the "if:
matrix.go-version" and "uses: codecov/codecov-action@b9fd7d16..." entries to
make the edit).

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: edcfb9de-af4f-4827-8987-762c2aa2f5bd

📥 Commits

Reviewing files that changed from the base of the PR and between de3d5b1 and 6fef84e.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

@mason-sharp

Copy link
Copy Markdown
Member Author

I reverted the code complexity related changes.

@mason-sharp
mason-sharp requested a review from rasifr April 14, 2026 19:00
@mason-sharp
mason-sharp merged commit 7cf0be1 into main Apr 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants