Integrate Numora as the numeric standard for Pendulum Portal - #653
Merged
Conversation
✅ Deploy Preview for rococo-souffle-a625f5 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ebma
approved these changes
Dec 30, 2025
ebma
left a comment
ebma
left a comment
Member
There was a problem hiding this comment.
Code looks good to me and I also tested the forms. Nice 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Summary
Replaces custom numeric input handling with Numora, a specialized DeFi library for financial inputs. This standardizes how the Pendulum Portal handles token amounts, balances, and swap interface inputs.
🎯 Key Changes
✅ Review Focus Areas
Verify all numeric input fields throughout the portal properly implement Numora
Test edge cases with maximum balance values, scientific notation inputs
Confirm BigNumber conversions remain accurate for blockchain transaction submissions
Validate that empty/invalid input states are handled gracefully without breaking existing validation logic