Clarify: isLoaded, loadFile, unloadFile#2015
Merged
Merged
Conversation
|
chchwy
approved these changes
May 20, 2026
github-project-automation
Bot
moved this from Needs Review
to Approved
in Pull Request Priority
github-project-automation
Bot
moved this from Approved
to Merged
in Pull Request Priority
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The methods are now documented. In addition I have also tweaked the unloadFile a bit, so it's no longer possible to unload the bitmap image without a valid backing image.
Let me know if you agree with this or not.. Previously i thought isLoaded was about whether the backing file has been loaded or not but looking at how we use it, that can't be. It seems to only be about whether the keyframe holds valid data in memory, which is slightly confusing with the name leaning towards loadFile, unloadFile.