LayerSound: Compare canonical paths (#2009)#2010
Merged
chchwy merged 1 commit intoMay 4, 2026
Merged
Conversation
MrStevns
changed the title
chchwy
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Updates LayerSound::saveKeyFrameFile() to compare canonical file paths (instead of raw strings) when deciding whether to remove/re-copy a sound file during project saves, addressing macOS path-root differences (e.g., /var vs /private/var) that can lead to save/zip corruption.
Changes:
- Compare
QFileInfo::canonicalFilePath()for source vs destination paths to avoid treating equivalent paths as different. - Introduce a
QFileInfofor the destination path to support canonical comparison. - Add an explanatory inline comment about the PCLX temp→project folder behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chchwy
force-pushed
the
bug/sound-layer-save-keyframe-same-path
branch
from
da50072 to
b4aa96b
Compare
Because if the root of the paths differentiate, even though the paths are technically the same, then this will fail and delete the only sound file there is and then fail to copy which will lead to project corruption.
chchwy
force-pushed
the
bug/sound-layer-save-keyframe-same-path
branch
from
b4aa96b to
bf1d1bc
Compare
|
chchwy
approved these changes
May 4, 2026
github-project-automation
Bot
moved this from Needs Review
to Approved
in Pull Request Priority
github-project-automation
Bot
moved this from Approved
to Merged
in Pull Request Priority
chchwy
pushed a commit
to chchwy/pencil2d
that referenced
this pull request
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because if the root of the paths differentiate, even though the paths are technically pointing to the correct file, then this will fail and delete the only sound file there is and then fail to copy which will lead to project corruption.
Related to #2009