Make custom zoom values accessible with arrow keys or mouse wheel#1926
Open
danpish wants to merge 2 commits into
Open
Make custom zoom values accessible with arrow keys or mouse wheel#1926danpish wants to merge 2 commits into
danpish wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I decided to attempt and fix this problem by the suggestion that was given in the issue #1651 and make it so that when:
1) A new custom value is inserted but no custom values are present in the zoom options, that value gets added.
2) A new custom value is inserted but a custom value already exists, that value would get replaced by the new one.
3) A non-custom value is inserted, any custom value that exists in the list would get removed.
However I could not figure out how to make the latter functional. Because when the value gets changed, either by manually inserting the number, or using either the arrow keys or the mouse wheel, all gets registered the same way and I don't know how differentiate different input methods. Would like to hear your suggestions.
fixes #1651