Repository navigation
refactor(qwen35): finish GDN review cleanup - #1241
Merged
FeathBow merged 1 commit intoNov 8, 2026
Merged
Conversation
Remove the unused public model loader, selector-impossible HF target cases and stale identity/stage-history prose left after PR pegainfer-project#862. Narrow the candidate recipe storage and preparation method to their owning module. Keep production validation, actual-model policy checks and HF thresholds. Document the pinned generation, release build, explicit candidate startup and HTTP verification steps in the existing tool README. Validation: release all-target builds and strict Clippy passed for the server, Qwen3.5 and kernels with the qwen35 feature; only README prose changed after the returned source hashes were checked. Rustfmt, Bash syntax, ShellCheck and diff checks pass. No new GPU or A/B run is claimed. Refs: pegainfer-project#862, pegainfer-project#691 Signed-off-by: qwzx-qwas <zzzt8047@gmail.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
8 of 10 tasks
FeathBow
approved these changes
Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up on the nonblocking review leftovers from merged #862. The model-loader wrapper has no remaining caller after the scheduler tests moved into the crate, and the HF gate constructs four invalid targets that the production selector cannot emit. Remove that wrapper and redundant loop, narrow recipe storage/preparation visibility, and retain the actual-model selection assertions, production rejection checks and numerical thresholds.
Remove retired identity-interface explanations and the private Stage 20 message. Add a short Quick Start covering the separate pinned generation environment, independent FlashInfer checkout, bundle generation, release build, explicit candidate selection and HTTP verification. Runtime algorithms, defaults, AOT contracts and shared tuning remain unchanged.
Related to #691; this cleanup does not complete that migration or close the issue. No private notes, delivery archives, generated objects, caches or raw results are included.
Type of Change
Validation
In response to the reviewer's request to run Clippy while hosted CI is having problems, the retained CUDA environment completed:
Build passed in 1m20s; Clippy passed in 39.89s, using nightly-2026-07-10 and CUDA 13.1.115 with the existing candidate linked. The returned evidence archive and internal hashes were verified, and its source manifest matches every current source/test file; only this PR's README prose was extended afterwards. The dependency future-compatibility notice for
proc-macro-error2remains in the log, with no compiler or Clippy error.Rustfmt, Bash syntax, local ShellCheck and
git diff --checkpassed. The build includes test targets but does not execute them. HF/HTTP/ABBA were not repeated for these removals, and the earlier #862 GPU results are not presented as a new run. Hosted CI on this follow-up remains to be checked.Checklist