Skip to content

refactor(qwen35): finish GDN review cleanup - #1241

Merged
FeathBow merged 1 commit into
pegainfer-project:mainfrom
qwzx-qwas:chore/qwen35-gdn-review-followup
Nov 8, 2026
Merged

FeathBow merged 1 commit into
pegainfer-project:mainfrom
qwzx-qwas:chore/qwen35-gdn-review-followup

Conversation

@qwzx-qwas

Copy link
Copy Markdown
Contributor

Description

Follow up on the nonblocking review leftovers from merged #862. The model-loader wrapper has no remaining caller after the scheduler tests moved into the crate, and the HF gate constructs four invalid targets that the production selector cannot emit. Remove that wrapper and redundant loop, narrow recipe storage/preparation visibility, and retain the actual-model selection assertions, production rejection checks and numerical thresholds.

Remove retired identity-interface explanations and the private Stage 20 message. Add a short Quick Start covering the separate pinned generation environment, independent FlashInfer checkout, bundle generation, release build, explicit candidate selection and HTTP verification. Runtime algorithms, defaults, AOT contracts and shared tuning remain unchanged.

Related to #691; this cleanup does not complete that migration or close the issue. No private notes, delivery archives, generated objects, caches or raw results are included.

Type of Change

  • Refactoring / review cleanup
  • Documentation update
  • New feature

Validation

In response to the reviewer's request to run Clippy while hosted CI is having problems, the retained CUDA environment completed:

cargo build --release --locked --offline \
  -p pegainfer-server -p pegainfer-qwen35 -p pegainfer-kernels \
  --all-targets --no-default-features --features qwen35

cargo clippy --release --locked --offline \
  -p pegainfer-server -p pegainfer-qwen35 -p pegainfer-kernels \
  --all-targets --no-default-features --features qwen35 -- -D warnings

Build passed in 1m20s; Clippy passed in 39.89s, using nightly-2026-07-10 and CUDA 13.1.115 with the existing candidate linked. The returned evidence archive and internal hashes were verified, and its source manifest matches every current source/test file; only this PR's README prose was extended afterwards. The dependency future-compatibility notice for proc-macro-error2 remains in the log, with no compiler or Clippy error.

Rustfmt, Bash syntax, local ShellCheck and git diff --check passed. The build includes test targets but does not execute them. HF/HTTP/ABBA were not repeated for these removals, and the earlier #862 GPU results are not presented as a new run. Hosted CI on this follow-up remains to be checked.

Checklist

  • Changes reviewed against the remaining feat(qwen35): add opt-in SM120 FlashInfer GDN prefill #862 comments.
  • Relevant compilation, strict Clippy, format and script checks passed.
  • Commitizen commit with matching Gmail author/committer and DCO sign-off.
  • Only the four reviewed files are included; no private/generated artifacts.
  • Hosted CI on this PR head has completed successfully.

Remove the unused public model loader, selector-impossible HF target cases
and stale identity/stage-history prose left after PR pegainfer-project#862. Narrow the
candidate recipe storage and preparation method to their owning module.
Keep production validation, actual-model policy checks and HF thresholds.

Document the pinned generation, release build, explicit candidate startup
and HTTP verification steps in the existing tool README.

Validation: release all-target builds and strict Clippy passed for the
server, Qwen3.5 and kernels with the qwen35 feature; only README prose
changed after the returned source hashes were checked. Rustfmt, Bash
syntax, ShellCheck and diff checks pass. No new GPU or A/B run is claimed.

Refs: pegainfer-project#862, pegainfer-project#691
Signed-off-by: qwzx-qwas <zzzt8047@gmail.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-08T11:19:28.812254Z b0391b7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added the qwen35 Qwen3.5 model crate (pegainfer-qwen35) label Nov 8, 2026
@FeathBow
FeathBow merged commit dc78afb into pegainfer-project:main Nov 8, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qwen35 Qwen3.5 model crate (pegainfer-qwen35)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants